Fix connection leak in CircuitBreaker fallback scenario with chunked responses#4104
Open
ban-xiu wants to merge 1 commit intospring-cloud:mainfrom
Open
Fix connection leak in CircuitBreaker fallback scenario with chunked responses#4104ban-xiu wants to merge 1 commit intospring-cloud:mainfrom
ban-xiu wants to merge 1 commit intospring-cloud:mainfrom
Conversation
Signed-off-by: lanbinshen <lanbinshen@xiaomi.com>
Author
|
@ryanjbaxter Thank you for your hard work reviewing this PR. I really appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Close #3978. When Spring Cloud Gateway uses CircuitBreaker with fallback, if the backend returns a response with chunked transfer encoding, the connection to the backend is not properly released, causing a connection pool leak. Eventually, the connection pool becomes exhausted, and subsequent requests fail with
504 GATEWAY_TIMEOUTdue toPoolAcquireTimeout.Root Cause
The issue is in
ServerWebExchangeUtils.reset()method. When CircuitBreaker triggers fallback, it callsreset(exchange)to prepare the exchange for the fallback request. However, the current implementation only:alreadyRoutedflagIt does not release the client connection stored in
CLIENT_RESPONSE_CONN_ATTR, which was established byNettyRoutingFilterto the backend.Connection leak flow:
Solution
Enhance
ServerWebExchangeUtils.reset()to properly dispose the client connection