This repository was archived by the owner on Aug 20, 2022. It is now read-only.
Updates DC list and allows unknown DC designators#38
Merged
briancline merged 1 commit intosoftlayer:masterfrom Mar 19, 2015
Merged
Updates DC list and allows unknown DC designators#38briancline merged 1 commit intosoftlayer:masterfrom
briancline merged 1 commit intosoftlayer:masterfrom
Conversation
Now, rather than raising an index error when a DC designator cannot be found, we go ahead and try to use the provided DC name to construct the auth URL anyway. This at least allows Swift in new DCs to be used without it needing to exist in the DC dict. Folks won't necessarily have to upgrade this package just to add new DCs. This doesn't fully remove the object_storage.DATACENTERS dict since someone could conceivably be referencing this list for something -- but it will be deprecated as constructing on the fly removes the need for these to be pre-defined.
briancline
added a commit
that referenced
this pull request
Mar 19, 2015
Updates DC list and allows unknown DC designators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, rather than raising an index error when a DC designator cannot be
found, we go ahead and try to use the provided DC name to construct the
auth URL anyway. This at least allows Swift in new DCs to be used
without it needing to exist in the DC dict. Folks won't necessarily
have to upgrade this package just to add new DCs.
This doesn't fully remove the object_storage.DATACENTERS dict since
someone could conceivably be referencing this list for something -- but
it will be deprecated as constructing on the fly removes the need for
these to be pre-defined.