Fix broken Korean IME composition on iOS Safari in CodeMirror editors#7965
Open
yunttai wants to merge 1 commit intorequarks:mainfrom
Open
Fix broken Korean IME composition on iOS Safari in CodeMirror editors#7965yunttai wants to merge 1 commit intorequarks:mainfrom
yunttai wants to merge 1 commit intorequarks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the CodeMirror-based Wiki.js editors to use the
textareainput path on iOS devices while preserving the existingcontenteditablepath elsewhere.Root Cause
The Markdown, AsciiDoc, and Code editors all use CodeMirror 5 with
inputStyle: "contenteditable". On iOS Safari, that input path can interfere with Korean IME composition and cause separated jamo, duplicated or missing characters, unexpected deletion, and cursor jumps.Wiki.js does not add its own composition or
beforeinputhandling around these editors, so the safest local mitigation point is the CodeMirror configuration used by the Wiki.js editor components.Changes
Why This Is Minimal And Safe
Validation
Manual real-device verification completed on an iPhone in Safari with the Korean keyboard:
Automated check completed:
jest --runTestsByPath client/helpers/codemirror.test.js --runInBandFull project test suite was not run as part of this change.