test/state/mouseEventsMiddleware.spec.ts (2)

98-106: Missing vi.useFakeTimers() in the new test suite.

Per coding guidelines, tests should use vi.useFakeTimers() due to Redux autoBatchEnhancer dependency on timers. The existing mouseClickMiddleware describe block at line 67 doesn't explicitly call it either, but it references vi.getTimerCount() which suggests fake timers are configured globally (likely in a setup file). However, for consistency and explicitness, consider adding beforeEach(() => vi.useFakeTimers()) to ensure the test suite is self-contained.

Also, the afterEach comment mentions clearing RAF handles from autoBatchEnhancer, which is good practice.

💡 Optional: Add explicit fake timers setup

 describe('mouseClickMiddleware – plot bounds guard', () => {
+  beforeEach(() => {
+    vi.useFakeTimers();
+  });
+
   afterEach(() => {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/state/mouseEventsMiddleware.spec.ts` around lines 98 - 106, The new
"mouseClickMiddleware – plot bounds guard" test suite is missing an explicit
call to vi.useFakeTimers(), so add a beforeEach hook inside the describe block
(the same block that contains the existing afterEach with vi.clearAllTimers())
to call vi.useFakeTimers() before each test; keep the existing afterEach that
clears RAF timers (vi.clearAllTimers()) so autoBatchEnhancer leftovers are
cleaned up.

---

146-166: Test coverage is adequate, but consider adding a note about the test setup.

This test correctly verifies that clicking inside the plot area does not dispatch mouseClickOutsidePlot. However, without tooltip ticks/data configured, selectActivePropsFromChartPointer returns undefined, so setMouseClickAxisIndex is never dispatched either. The tooltip remains active simply because no deactivating action occurs.

This is fine for testing the bounds guard itself, but a comment clarifying this behavior would help future maintainers understand the test's intent.

📝 Optional: Add clarifying comment

   it('should NOT deactivate the tooltip when clicking inside the plot area', () => {
     const store = createStoreWithChartDimensions();

-    // Pre-activate the tooltip
+    // Pre-activate the tooltip. Note: without tooltip ticks/data, the middleware
+    // won't dispatch setMouseClickAxisIndex, but the key assertion is that
+    // mouseClickOutsidePlot is NOT dispatched for in-range clicks.
     store.dispatch(

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/state/mouseEventsMiddleware.spec.ts` around lines 146 - 166, Add an
inline clarifying comment in the test (near the pre-activation and the
mouseClickAction(INSIDE_PLOT) dispatch) explaining that because no tooltip
ticks/data are configured, selectActivePropsFromChartPointer will return
undefined so setMouseClickAxisIndex is not dispatched and the tooltip remains
active only because no deactivating action occurs; reference the related symbols
setMouseClickAxisIndex, selectActivePropsFromChartPointer, mouseClickAction and
mouseClickOutsidePlot in the comment so future maintainers understand the test's
intent.

src/state/mouseEventsMiddleware.ts (1)

29-29: Remove debug logging from middleware path.

Line 29 leaves a console.log in production event handling.

Suggested fix

-    console.log({ chartX, chartY, outerWidth, outerHeight, offset });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/state/mouseEventsMiddleware.ts` at line 29, Remove the leftover
console.log call that prints { chartX, chartY, outerWidth, outerHeight, offset }
from the middleware path in mouseEventsMiddleware.ts; either delete the
console.log or replace it with a proper logger call gated by a debug/verbose
flag (e.g., use existing logging utility or process.env.DEBUG) so production
doesn't emit these event logs, locating the statement that references chartX,
chartY, outerWidth, outerHeight, and offset and removing or wrapping it
accordingly.

www/src/components/Playground/AnnotationsPanel.tsx (1)

14-16: Update JSDoc to match the new portal/component naming.

The comment still refers to the annotations portal/controller, but the component now renders RechartsDevtoolsPortal. Aligning this text will reduce confusion during maintenance.

✏️ Suggested doc-only update

 /**
- * A panel that renders the Recharts Annotations portal.
- * This is the container where the AnnotationsController UI will be rendered.
+ * A panel that renders the Recharts Devtools portal.
+ * This is the container where the devtools UI will be rendered.
  */

Based on learnings: When making changes to Recharts code, prefer current best practices as described in CONTRIBUTING.md and try to improve code style where relevant to the current task.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@www/src/components/Playground/AnnotationsPanel.tsx` around lines 14 - 16,
Update the JSDoc at the top of the AnnotationsPanel component so it describes
rendering the RechartsDevtoolsPortal rather than the old "AnnotationsController"
or "annotations portal"; locate the JSDoc block above the AnnotationsPanel
component declaration and replace the outdated wording with a concise
description that this panel is the container where the RechartsDevtoolsPortal UI
will be rendered, keeping tone and style consistent with surrounding comments.