Fix Chrome restart, enhance connection options and logging#779
Open
turicas wants to merge 4 commits intoprerender:masterfrom
Open
Fix Chrome restart, enhance connection options and logging#779turicas wants to merge 4 commits intoprerender:masterfrom
turicas wants to merge 4 commits intoprerender:masterfrom
Conversation
This will make possible to connect in browsers running on other hosts or even forcing IPv4 or IPv6.
1c0a93c to
20aefcf
Compare
The main browser process is now spawn detached, which mean it'll be the group owner of its children (Chrome will spawn new processes). This way we can send a SIGINT for the whole group and fix the restart procedure (before this change prerender could not connect to the browser after a restart).
Author
|
I deployed the latest version of this branch with this custom |
boldtrn
added a commit
to boldtrn/prerender-alpine
that referenced
this pull request
Apr 18, 2024
boldtrn
added a commit
to boldtrn/prerender-alpine
that referenced
this pull request
Apr 18, 2024
This reverts commit 7ae9fe7.
|
Any progress on this one? |
|
Is there a chance this will be merged? |
Ashwin-op
added a commit
to commudle/prerender
that referenced
this pull request
Sep 22, 2025
…nection) and preserve fork options
|
Is this repository still maintained @thoop? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of changes:
chrome.connectandchrome.openTabProbably related to/fixes #761 #775 #758 #755 #753