Implement HOST and PORT to replace the unimplemented PRERENDER_SERVICE_URL#658
Open
dns2utf8 wants to merge 2 commits intoprerender:masterfrom
Open
Implement HOST and PORT to replace the unimplemented PRERENDER_SERVICE_URL#658dns2utf8 wants to merge 2 commits intoprerender:masterfrom
dns2utf8 wants to merge 2 commits intoprerender:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all
One of my machines was exploited as a relay because the PRERENDER_SERVICE_URL was not honoured by the code.
So I implemented HOST and PORT separately to give more control to the users.
Cheers,
Stefan
PS: I may have misunderstood the use of the
PRERENDER_SERVICE_URL. However, I still believe this is an useful addition.