Window API will return Window Rect#804
Open
oleg-andreyev wants to merge 4 commits intophp-webdriver:mainfrom
Open
Window API will return Window Rect#804oleg-andreyev wants to merge 4 commits intophp-webdriver:mainfrom
oleg-andreyev wants to merge 4 commits intophp-webdriver:mainfrom
Conversation
williamdes
approved these changes
Jun 23, 2020
03d86e3 to
f0b65fb
Compare
f0b65fb to
2816cf6
Compare
williamdes
suggested changes
Mar 15, 2021
Collaborator
williamdes
left a comment
There was a problem hiding this comment.
This PR adds BC breaks, maybe -> v2
Contributor
Author
|
Yes, I think this was discussed with @OndraM in PR comments |
Contributor
Author
Collaborator
…window rect, which could be useful for consumers
b670d2a to
f37e591
Compare
williamdes
reviewed
Mar 21, 2021
Contributor
Author
|
@OndraM please take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on specifications Window API, window size manipulation returns window rect, which could be useful for consumers
Ref.:
Because it's an API change, it can only go into the main branch and major version release.
To Do: