Fixed possible deadlock after cleaning up lambda server#355
Open
bridgetwu33 wants to merge 3 commits intoopen-lambda:mainfrom
Open
Fixed possible deadlock after cleaning up lambda server#355bridgetwu33 wants to merge 3 commits intoopen-lambda:mainfrom
bridgetwu33 wants to merge 3 commits intoopen-lambda:mainfrom
Conversation
tylerharter
requested changes
Nov 28, 2025
go/worker/event/lambdaServer.go
Outdated
| // components represent run[0]/<name_of_sandbox>[1]/<extra_things>... | ||
| // ergo we want [1] for name of sandbox | ||
| urlParts := getURLComponents(r) | ||
| w.Header().Set("Content-Type", "text/plain; charset=utf-8") |
Member
There was a problem hiding this comment.
Is this right? When we do f.Invoke, isn't it possible the user code might want to use a different content type (e.g., json)?
69cb080 to
5d1f156
Compare
5d1f156 to
e153059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, main would not return nil on success. During server cleanup, we acquire a lock and never unlock it to stop accepting new requests.
Since main now returns nil on success, we now unlock after killing sandbox and zygotes. Any requests to the lambda server now check if the lambda server is closed.