Update environment-routes.component.html#1793
Open
sugita-mf wants to merge 5 commits intomockoon:mainfrom
Open
Update environment-routes.component.html#1793sugita-mf wants to merge 5 commits intomockoon:mainfrom
sugita-mf wants to merge 5 commits intomockoon:mainfrom
Conversation
feat: add default response flag indicator next to dropdown
Author
Author
|
I did them for fixing CI's error. I have fixed the Prettier formatting issue in environment-routes.component.html on the patch-1 branch and pushed the changes to my fork. |
Member
|
I didn't test your PR yet, but I would say adding the flag indicator on the dropdown button could make sense. From the top of my mind:
|
Author
|
Author
Member
|
Thanks for the changes. However, we need to keep the same design:
I guess the easiest way to achieve this is to create an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical implementation details
Added a flag icon indicator next to the response dropdown button that shows the current default response status. The implementation:
Uses existing setDefaultRouteResponse function for consistency
Follows the same styling pattern as dropdown menu flags (text-primary for default, text-muted for non-default)
Only displays for HTTP and WebSocket routes with responses
Maintains existing flag icons inside dropdown menu
Uses ngbTooltip for user guidance
Responsive design with proper spacing (ms-2)
Checklist
[x] data migration added (@mockoon/commons) - Not needed, no data structure changes
[x] commons lib tests added (@mockoon/commons) - Not needed, no commons changes
[x] commons-server lib tests added (@mockoon/commons-server) - Not needed, no server changes
[x] CLI tests added (@mockoon/cli) - Not needed, no CLI changes
[x] desktop UI automated tests added (@mockoon/app) - Should be added for UI interaction
Note: Most checklist items are not applicable as this is a UI-only change that doesn't affect data structures, server logic, or CLI functionality. Only desktop UI tests would be relevant.
Closes #1792