Skip to content

Fix _ScaledRotation invalidation and set mathtext thumbnail#31351

Closed
manasvi-sahare wants to merge 1 commit intomatplotlib:mainfrom
manasvi-sahare:fix-mathtext-thumbnail
Closed

Fix _ScaledRotation invalidation and set mathtext thumbnail#31351
manasvi-sahare wants to merge 1 commit intomatplotlib:mainfrom
manasvi-sahare:fix-mathtext-thumbnail

Conversation

@manasvi-sahare
Copy link

This PR includes two changes:

  1. Fixes _ScaledRotation.get_matrix() by resetting _invalid and _inverted after computing the matrix, ensuring proper caching and avoiding unnecessary recomputation.
  2. Adds # sphinx_gallery_thumbnail_number = 1 to the Mathtext tutorial to set a meaningful thumbnail in the gallery.

@github-actions
Copy link

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@rcomer
Copy link
Member

rcomer commented Mar 23, 2026

  • The mathtext section already uses the first thumbnail
  • Since there is no code change here, it cannot be fixing anything
  • Changes to address different problems should go in separate PRs
  • We require new contributors to use our pull request template for the summary

I'm sorry but I do not think there is anything we can use here, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants