Skip to content

Add helper functions for number checks and validations #31350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohdabid4333-dotcom wants to merge 1 commit into from
+17 −0
Closed

Add helper functions for number checks and validations #31350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lib/matplotlib/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,23 @@

_log = logging.getLogger(__name__)

# Fixed helper functions
def _is_close_to_int(x):

Check warning on line 149 in lib/matplotlib/ticker.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Expected 2 blank lines, found 1

Raw Output:
message:"Expected 2 blank lines, found 1"  location:{path:"?url=https%3A%2F%2Fgithub.com%2Fhome%2Frunner%2Fwork%2Fmatplotlib%2Fmatplotlib%2Flib%2Fmatplotlib%2Fticker.py"  range:{start:{line:149  column:1}  end:{line:149  column:4}}}  severity:WARNING  source:{name:"ruff"  url:"https://docs.astral.sh/ruff"}  code:{value:"E302"  url:"https://docs.astral.sh/ruff/rules/blank-lines-top-level"}  suggestions:{range:{start:{line:147  column:1}  end:{line:147  column:1}}  text:"\n"}
"""Return True if x is close to an integer."""
return math.isclose(x, round(x), rel_tol=1e-9)

def _is_decade(x, *, base=10, rtol=None):

Check warning on line 153 in lib/matplotlib/ticker.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Expected 2 blank lines, found 1

Raw Output:
message:"Expected 2 blank lines, found 1"  location:{path:"?url=https%3A%2F%2Fgithub.com%2Fhome%2Frunner%2Fwork%2Fmatplotlib%2Fmatplotlib%2Flib%2Fmatplotlib%2Fticker.py"  range:{start:{line:153  column:1}  end:{line:153  column:4}}}  severity:WARNING  source:{name:"ruff"  url:"https://docs.astral.sh/ruff"}  code:{value:"E302"  url:"https://docs.astral.sh/ruff/rules/blank-lines-top-level"}  suggestions:{range:{start:{line:152  column:1}  end:{line:153  column:1}}  text:"\n\n"}
"""Return True if *x* is an integer power of *base*."""
if not np.isfinite(x):
return False
if x == 0.0:
return True
lx = np.log(abs(x)) / np.log(base)
if rtol is None:
return np.isclose(lx, np.round(lx))
else:
return np.isclose(lx, np.round(lx), rtol=rtol)

__all__ = ('TickHelper', 'Formatter', 'FixedFormatter',
'NullFormatter', 'FuncFormatter', 'FormatStrFormatter',
'StrMethodFormatter', 'ScalarFormatter', 'LogFormatter',
Expand Down
Loading