feat(browser): add cursor animations for click and scroll actions#23420
feat(browser): add cursor animations for click and scroll actions#23420kunal-10-cloud wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
- Add mousedown-based pre-click listener with double-registration guard and 3-second safety timeout for click/hover tool animations - Add post-click ripple animation for click_at(x, y) coordinates - Add cascading arrow panel scroll animation with staggered arrows - Use Web Animations API for CSP compatibility - Add showCursorAnimations config option (default: true in non-headless) - All animations are aria-hidden, pointer-events:none, and self-removing - Errors in animation injection never block tool execution
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the browser agent by providing real-time visual feedback during automated interactions. By displaying animations for clicks and scrolls directly within the browser window, users can more easily observe and understand the agent's actions, which is particularly beneficial for debugging and validating automation flows. This feature improves the user experience by making the agent's operations more transparent and intuitive. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @cynthialong0-0, I have raised a clean new PR and closed the previous one |
There was a problem hiding this comment.
Code Review
This pull request introduces visual feedback for browser automation by adding cursor animations for click and scroll actions. The implementation is robust, featuring a new configuration option showCursorAnimations, CSP-compatible animations using the Web Animations API, and graceful error handling that prevents animation failures from blocking tool execution. The changes are well-tested with new unit and integration tests. The code is clean and follows best practices for injecting and managing transient UI elements in a web page. No critical or high-severity issues were found in this review.
Summary
This PR implements visual feedback for browser agent automation by adding cursor animations for click and scroll actions. These animations provide real-time visual cues in the browser window, enhancing transparency and aiding debugging by highlighting exactly where and how the agent is interacting with the page.
Details
Related Issues
Closes #21099
How to Validate
Run the Following test suites to verify configuration and injection logic:
npm run test -w @google/gemini-cli-corePre-Merge Checklist