Mark RenderParagraph layout dirty when textAlign changes#183942
Open
mayanksharma9 wants to merge 1 commit intoflutter:masterfrom
Open
Mark RenderParagraph layout dirty when textAlign changes#183942mayanksharma9 wants to merge 1 commit intoflutter:masterfrom
mayanksharma9 wants to merge 1 commit intoflutter:masterfrom
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
RenderParagraph.textAlignto callmarkNeedsLayout()when the alignment value changes.Without this, changing
textAligncan leave layout stale because alignment affects line metrics and positioning. This change ensures paragraph layout is recomputed immediately when alignment updates.Fixes #140756.
Pre-launch Checklist
///).