fix: return successful scrapes for empty 2xx pages#3131
Open
tsubasakong wants to merge 2 commits intofirecrawl:mainfrom
Open
fix: return successful scrapes for empty 2xx pages#3131tsubasakong wants to merge 2 commits intofirecrawl:mainfrom
tsubasakong wants to merge 2 commits intofirecrawl:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/api/src/scraper/scrapeURL/emptyPage.ts">
<violation number="1" location="apps/api/src/scraper/scrapeURL/emptyPage.ts:2">
P2: Empty-page detection can produce false negatives (head-only/bodyless docs and non-` ` invisible entities), causing valid empty 2xx scrapes to be marked unsuccessful.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -0,0 +1,16 @@ | |||
| export function hasNoExtractableText(html: string): boolean { | |||
| const body = html.match(/<body\b[^>]*>([\s\S]*?)<\/body>/i)?.[1] ?? html; | |||
Contributor
There was a problem hiding this comment.
P2: Empty-page detection can produce false negatives (head-only/bodyless docs and non- invisible entities), causing valid empty 2xx scrapes to be marked unsuccessful.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/src/scraper/scrapeURL/emptyPage.ts, line 2:
<comment>Empty-page detection can produce false negatives (head-only/bodyless docs and non-` ` invisible entities), causing valid empty 2xx scrapes to be marked unsuccessful.</comment>
<file context>
@@ -0,0 +1,16 @@
+export function hasNoExtractableText(html: string): boolean {
+ const body = html.match(/<body\b[^>]*>([\s\S]*?)<\/body>/i)?.[1] ?? html;
+
+ const text = body
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCRAPE_ALL_ENGINES_FAILEDTesting
pnpm exec jest src/scraper/scrapeURL/empty-page.test.ts --runInBandgit diff --checkNotes
.github/at checkout timeSummary by cubic
Treat 2xx scrapes with no page error and no extractable text as successful to prevent false
SCRAPE_ALL_ENGINES_FAILEDand avoid unnecessary fallbacks. AddshasNoExtractableTextand updates quality logs and tests.isExplicitlyEmptyPagein success/failure and proxy-adequacy logs.hasNoExtractableText.Written for commit a6c4229. Summary will update on new commits.