chore: Add Location to CommonRequestHeadersList types#7528
Open
joaoGabriel55 wants to merge 1 commit intoaxios:v1.xfrom
Open
chore: Add Location to CommonRequestHeadersList types#7528joaoGabriel55 wants to merge 1 commit intoaxios:v1.xfrom
joaoGabriel55 wants to merge 1 commit intoaxios:v1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7527
Adds the
Locationheader to theCommonRequestHeadersListTypeScript type in bothindex.d.tsandindex.d.cts. Based on the MDN Headers docs: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers#redirectsMotivation
The
Locationheader is a commonly used HTTP header (e.g., in redirect responses and certain request scenarios), but it was missing from theCommonRequestHeadersListunion type. This meant that accessing or setting theLocationheader through Axios's typed header APIs did not benefit from type-safe autocompletion or validation.Changes
index.d.ts— Added"Location"to theCommonRequestHeadersListunion type.index.d.cts— Added'Location'to theCommonRequestHeadersListunion type (CJS types).Checklist
.d.tsand.d.ctstype files updated consistentlySummary by cubic
Adds the
Locationheader to theCommonRequestHeadersListTypeScript type for better IntelliSense and type safety inaxios. Type-only change inindex.d.tsandindex.d.cts.Description
CommonRequestHeadersListinindex.d.tsandindex.d.cts.Location.Docs
Testing
Written for commit 083a29e. Summary will update on new commits.