refactor(types): use TypeScript utils to transform duplicated literals#7520
Open
tryonelove wants to merge 5 commits intoaxios:v1.xfrom
Open
refactor(types): use TypeScript utils to transform duplicated literals#7520tryonelove wants to merge 5 commits intoaxios:v1.xfrom
tryonelove wants to merge 5 commits intoaxios:v1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7519
Summary by cubic
Simplified
axiosMethodandresponseEncodingtypes using TypeScript string utilities to remove duplicates while keeping case-insensitive support. Types-only change with no runtime impact; fixes #7519.Description
UppercaseMethod/UppercaseResponseEncoding+Lowercase<>inindex.d.tsandindex.d.cts.responseEncodingexport inindex.d.cts(public API unchanged).Testing
MethodandresponseEncoding.Written for commit 5b54575. Summary will update on new commits.