Skip to content

docs(buildURL): align encode() comment with current behavior#7475

Open
nthbotast wants to merge 1 commit intoaxios:v1.xfrom
nthbotast:docs/update-encode-comment-7474
Open

docs(buildURL): align encode() comment with current behavior#7475
nthbotast wants to merge 1 commit intoaxios:v1.xfrom
nthbotast:docs/update-encode-comment-7474

Conversation

@nthbotast
Copy link
Contributor

@nthbotast nthbotast commented Mar 4, 2026

Summary

  • update encode() JSDoc in lib/helpers/buildURL.js
  • remove mention of +, [ and ] replacements that no longer happen
  • clarify that spaces are encoded as +

Testing

  • not run (comment-only change)

Fixes #7474


Summary by cubic

Updated the encode() JSDoc in lib/helpers/buildURL.js to match actual behavior: it encodes ':', '$', ',', and spaces (spaces -> '+') and no longer claims '+', '[' and ']' are encoded. Fixes #7474.

Docs

  • Corrected the encode() JSDoc to reflect current encoding behavior.

Testing

  • No code changes; no tests added or needed.

Written for commit a4f3fde. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The comment of the function encode() not updated after fix the issue 3316 in the issue 5715

1 participant