fix: use TreeMap to ensure consistent iteration order in ThreadPoolStatusChecker#16154
Open
Senrian wants to merge 1 commit intoapache:3.3from
Open
fix: use TreeMap to ensure consistent iteration order in ThreadPoolStatusChecker#16154Senrian wants to merge 1 commit intoapache:3.3from
Senrian wants to merge 1 commit intoapache:3.3from
Conversation
Fixes the flaky test ThreadPoolStatusCheckerTest where Map.entrySet() iteration order is undefined. Using TreeMap sorts entries by port key, making the status message deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fix the flaky test
ThreadPoolStatusCheckerTestwhereMap.entrySet()iteration order is undefined under the Java Memory Model, causing test failures when the map returns entries in a different order than expected.Fix
Use
TreeMapinstead of rawMapto sort entries by port key before building the status message. This guarantees deterministic output regardless of JVM implementation or hash map iteration order.Fixes #16152
Fixes #16153