fix(interaction): brushXFilter/brushYFilter should not modify the non-filtered axis scale#7280
Draft
fix(interaction): brushXFilter/brushYFilter should not modify the non-filtered axis scale#7280
Conversation
…cks (#7272) Co-authored-by: moayuisuda <37040897+moayuisuda@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue 7272
fix(interaction): brushXFilter/brushYFilter should not modify the non-filtered axis scale
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brushXFilterwas hiding and overwriting the Y axis scale domain (and vice versa forbrushYFilter), causing Y axis ticks to change after an X-only brush filter operation.Root causes
BrushFilterdefaultedhideY: truefor all subclasses, includingBrushXFilter— causing the Y axis to flash hide/show during re-render, appearing as a tick changeBrushFilterunconditionally set bothscale.x.domainandscale.y.domainwithnice: false, even when only one axis was being filtered — potentially producing different tick positions than the original scaleChanges
brushFilter.ts: AddfilterXandfilterYboolean params toBrushFilter. Scale domains are only updated for axes where the corresponding flag istrue:brushXFilter.ts: PasshideY: false, filterY: false— Y axis is unaffected when filtering XbrushYFilter.ts: PasshideX: false, filterX: false— X axis is unaffected when filtering Yinteraction.spec.ts: Add unit tests asserting Y domain is unchanged afterbrushXFilterand X domain is unchanged afterbrushYFilter📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.