test(forms): support directive composition with FormField#67660
Open
leonsenft wants to merge 1 commit intoangular:mainfrom
Open
test(forms): support directive composition with FormField#67660leonsenft wants to merge 1 commit intoangular:mainfrom
FormField#67660leonsenft wants to merge 1 commit intoangular:mainfrom
Conversation
Support composing the `FormField` directive with custom controls:
```ts
import {FormField, FormValueControl} from '@angular/forms/signals';
@component({
hostDirectives: [
{directive: FormField, inputs: ['formField']},
],
})
export class MyControl implements FormValueControl<...> { ... }
```
IMPORTANT: The `formField` input _must_ be exposed as-is, without
aliasing to function properly.
For more on directive composition, see
https://angular.dev/guide/directives/directive-composition-api.
1efe2a0 to
f84f5d5
Compare
Contributor
Author
|
@arm1n Please let me know if this fails to address your use case, at head |
kirjs
approved these changes
Mar 24, 2026
|
|
||
| @Component({ | ||
| selector: 'custom-control', | ||
| host: {'tabindex': '-1'}, |
kirjs
reviewed
Mar 24, 2026
| expect(comp.customControl().errors()).toEqual([]); | ||
| }); | ||
|
|
||
| it('should bind to a custom control when composed as a host directive', () => { |
kirjs
reviewed
Mar 24, 2026
| expect(component.customControl().required()).toBe(true); | ||
| }); | ||
|
|
||
| it('should bind to a custom control when composed as a host directive', () => { |
Contributor
There was a problem hiding this comment.
There are like 15 tests with the same name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support composing the
FormFielddirective with custom controls:IMPORTANT: The
formFieldinput must be exposed as-is, without aliasing to function properly.For more on directive composition, see
https://angular.dev/guide/directives/directive-composition-api.