Open
Conversation
ionmincu
reviewed
Mar 20, 2026
| from ._utils._service_base import ServiceCommandBase, service_command | ||
|
|
||
|
|
||
| @click.command(name="list-models") |
Contributor
There was a problem hiding this comment.
i would also add a testcase for this 😄 , or alter an existing one to also run this cli command
radu-mocanu
reviewed
Mar 22, 2026
| "debug": "cli_debug", | ||
| "assets": "services.cli_assets", | ||
| "buckets": "services.cli_buckets", | ||
| "list-models": "cli_list_models", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "list-models": "cli_list_models", | |
| "list models": "cli_list_models", |
we should follow a standard format for CLI commands
list models
list buckets
list assets
etc.
Collaborator
There was a problem hiding this comment.
I would create a generic cli_list, similar to cli_add and match by resource type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.