Replace red-herring warning around process aliasing get-process with warning around invalid syntax#1638
Merged
rjmholt merged 2 commits intoPowerShell:masterfrom Apr 21, 2021
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1402 by not warning around
processaliasingget-processbut rather that there is likely invalid syntax around the proces block since it is technically not possible to executeprocessas a command.It would be better to have a rule of it's own for checking the begin/process/end blocks within a scriptblock but issue #1571 tracks this. This PR fixes the red-herring warning, whilst also giving a better warning to the user in the short term.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.