ECOM-7571 Add missing fields to item taxes and item itself about handling breakdown and its taxation#551
Open
OlegShtchLS wants to merge 2 commits intomasterfrom
Open
ECOM-7571 Add missing fields to item taxes and item itself about handling breakdown and its taxation#551OlegShtchLS wants to merge 2 commits intomasterfrom
OlegShtchLS wants to merge 2 commits intomasterfrom
Conversation
Alexis2004
requested changes
Mar 19, 2026
| val taxType: OrderItemTaxType? = null, | ||
| val includeInPrice: Boolean? = null, | ||
| val taxOnDiscountedSubtotal: Double? = null, | ||
| val taxOnShipping: Double? = null |
Contributor
There was a problem hiding this comment.
А это поле точно приходит nullable с бекенда? Скорее всего там просто 0.0
Contributor
Author
There was a problem hiding this comment.
Да, если я правильно вижу, что оно apigate десериализуется в ru.cdev.xnext.client.order.OrderItemTax, то оно может быть выставлено в null
И я смотрю, что это поле есть с именем taxOnHandlingFee. Сейчас поправлю...
`taxOnHandlingFee` relates to `ru.cdev.xnext.client.order.OrderItemTax`'s fields same as `taxOnShipping`.
`handlingFee` contains breakdown of only handling fee for the item same as `shipping` contains breakdown of only shipping cost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional fields for ECOM-7571.
Errors in checks aren't related to changes.