Fix: Form field filters not applied when no validators are specified#16855
Draft
Fix: Form field filters not applied when no validators are specified#16855
Conversation
…sValid() Co-authored-by: niden <1073784+niden@users.noreply.github.com> Agent-Logs-Url: https://github.com/phalcon/cphalcon/sessions/ac64751e-b9d5-42f7-8c36-ad6bc64d04f1
Copilot
AI
changed the title
[WIP] Fix field filters not working without validators
Fix: Form field filters not applied when no validators are specified
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Form::isValid(), elements with no validators were skipped entirely via an earlycontinue, preventing any registered filters from being applied to the bound entity. Regression introduced in 5.10.0.Before fix:
entity->test1 === ' '(spaces preserved),entity->test2 === ''(trimmed)After fix: both fields correctly trimmed to
''Changes
phalcon/Forms/Form.zep— InisValid(), movegetFilters()before the early-continue guard and change the condition to skip only when both validators and filters are absent:tests/integration/Forms/Form/IsValidCest.php— AddformsFormIsValidAppliesFiltersWithoutValidatorsregression test covering both the no-validator and with-validator cases.In raising this pull request, I confirm the following:
Thanks
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.